mschoi/RustPython
1
0
Fork 0
forked from Rust-related/RustPython
Code Pull Requests Actions Activity

Optimize Py<PyDict>::to_attributes() to reuse PyRefExact

Browse Source
This commit is contained in:
Zhiyan Xiao
2023-02-17 07:23:19 +09:00
parent 57fd8c97b4
commit 9206ad52b8
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
vm/src/builtins/dict.rs
View File

@@ -1,6 +1,6 @@
use super::{
set::PySetInner, IterStatus, PositionIterInternal, PyBaseExceptionRef, PyGenericAlias,
PyMappingProxy, PySet, PyStrRef, PyTupleRef, PyType, PyTypeRef,
PyMappingProxy, PySet, PyStr, PyTupleRef, PyType, PyTypeRef,
};
use crate::{
atomic_func,
@@ -534,9 +534,8 @@ impl Py<PyDict> {
pub fn to_attributes(&self, vm: &VirtualMachine) -> PyAttributes {
let mut attrs = PyAttributes::default();
for (key, value) in self {
// TODO: use PyRefExact for interning
let key: PyStrRef = key.downcast().expect("dict has non-string keys");
attrs.insert(vm.ctx.intern_str(key.as_str()), value);
let key: PyRefExact<PyStr> = key.downcast_exact(vm).expect("dict has non-string keys");
attrs.insert(vm.ctx.intern_str(key), value);
}
attrs
}