mschoi/3Dmol.js
1
0
Fork 0
mirror of https://github.com/3dmol/3Dmol.js.git synced 2026-06-04 08:39:49 +09:00
Code Issues Packages Projects Releases Wiki Activity

Guard calls to this._gl.drawingBufferWidth with isLost check.

Browse Source 
Skipping these guards can cause problems in colab (apparently, Issue
This commit is contained in:
David Koes
2025-09-25 22:53:40 -04:00
parent 9dd8e4d649
commit c433379854
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/WebGL/Renderer.ts
View File

@@ -310,13 +310,11 @@ export class Renderer {
) {
//note that drawingBuffer may be smaller than the requested width
//for large canvases
var wid = this._gl.drawingBufferWidth / this.cols;
var hei = this._gl.drawingBufferHeight / this.rows;
this._viewportWidth = wid;
this._viewportHeight = hei;
if (!this.isLost()) {
if(!this.isLost()) {
var wid = this._gl.drawingBufferWidth / this.cols;
var hei = this._gl.drawingBufferHeight / this.rows;
this._viewportWidth = wid;
this._viewportHeight = hei;
this._gl.enable(this._gl.SCISSOR_TEST);
this._gl.scissor(wid * this.col, hei * this.row, wid, hei);
this._gl.viewport(wid * this.col, hei * this.row, wid, hei);
@@ -342,13 +340,10 @@ export class Renderer {
this.row != undefined &&
this.col != undefined
) {
var wid = width / this.cols;
var hei = height / this.rows;
this._viewportWidth = wid * this.devicePixelRatio;
this._viewportHeight = hei * this.devicePixelRatio;
this._viewportWidth = this._gl.drawingBufferWidth /this.cols;
this._viewportHeight = this._gl.drawingBufferHeight/this.rows;
if (!this.isLost()) {
this._viewportWidth = this._gl.drawingBufferWidth /this.cols;
this._viewportHeight = this._gl.drawingBufferHeight/this.rows;
}
this.setViewport();
} else {