Rust-related/RustPython
1
0
Fork 1
mirror of https://github.com/RustPython/RustPython.git synced 2026-06-09 22:49:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2903 from Snowapril/fix-syntax-test

Browse Source 
Add syntax error detection routine for global symbol
This commit is contained in:
Jeong YunWon
2021-08-18 01:27:44 +09:00
committed by GitHub
parent f20bb6cac7 38237c30d3
commit 1d89e633dc
2 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/test/test_syntax.py
View File

@@ -673,8 +673,6 @@ class SyntaxTestCase(unittest.TestCase):
def test_assign_del(self):
self._check_error("del f()", "delete")
# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_global_param_err_first(self):
source = """if 1:
def error(a):

34
compiler/src/symboltable.rs
View File

@@ -1121,10 +1121,36 @@ impl SymbolTableBuilder {
match role {
SymbolUsage::Global => {
if !symbol.is_global() {
return Err(SymbolTableError {
error: format!("name '{}' is used prior to global declaration", name),
location,
});
if symbol.is_parameter {
return Err(SymbolTableError {
error: format!("name '{}' is parameter and global", name),
location,
});
}
if symbol.is_referenced {
return Err(SymbolTableError {
error: format!(
"name '{}' is used prior to global declaration",
name
),
location,
});
}
if symbol.is_annotated {
return Err(SymbolTableError {
error: format!("annotated name '{}' can't be global", name),
location,
});
}
if symbol.is_assigned {
return Err(SymbolTableError {
error: format!(
"name '{}' is assigned to before global declaration",
name
),
location,
});
}
}
}
SymbolUsage::Nonlocal => {