Erich Gubler 7214da6820 Fix missing validation for Device::clear_buffer where offset + size > buffer.size was not checked when size was omitted. (#5282) ...

style: fix fmt. of `assert!(…)` in `clear_texture_via_buffer_copies`

refactor: `command_encoder_clear_buffer`: s/end/end_offset

fix: always check buffer clear `offset` for OOB

Fuzz testing in Firefox encountered crashes for calls of
`Global::command_encoder_clear_buffer` where:

* `offset` is greater than `buffer.size`, but…
* `size` is `None`.

Oops! We should _always_ check this (i.e., even when `size` is `None`),
because we have no guarantee that `offset` and the fallback value of
`size` is in bounds. 😅 So, we change validation here to unconditionally
compute `size` and run checks we previously gated behind `if let
Some(size) = size { … }`.

For convenience, the spec. link for this method:
<https://gpuweb.github.io/gpuweb/#dom-gpucommandencoder-clearbuffer>

fix: `command_encoder_clear_buffer`: err. on `offset + size > u64::MAX`

Rust would have made this operation either an overflow in release mode,
or a panic in debug mode. Neither seem appropriate for this context,
where I suspect an error should be returned instead. Web browsers, for
instance, shouldn't crash simply because of an issue of this nature.
Users may, quite reasonably, have bad arguments to this in early stages
of development!

2024-02-29 17:00:09 -05:00

..

src

Allow WebGPU & WebGL in same wasm and detect WebGPU availability (#5044)

2024-01-14 09:45:52 +00:00

tests

Fix missing validation for Device::clear_buffer where offset + size > buffer.size was not checked when size was omitted. (#5282)

2024-02-29 17:00:09 -05:00

Cargo.toml

Revamp Examples to Match Website (#4765)

2023-11-25 17:20:11 -05:00