mirror of
https://github.com/torvalds/linux
synced 2026-07-22 02:00:44 +09:00
80ec8054fe
The new get-reqs dump operations added to sunrpc_cache.yaml and
nfsd.yaml place the "requests" nested attribute under dump.request.
A netlink dump carries an empty request; its payload travels back
in the reply. Because the spec names no reply attributes, the YNL
C code generator synthesizes a forward reference to a
<op>_rsp struct that is never defined, breaking any consumer of
these specs.
This first surfaced when Thorsten Leemhuis built tools/net/ynl
against -next:
nfsd-user.h:746: error: field 'obj' has incomplete type
struct nfsd_svc_export_get_reqs_rsp obj ...
nfsd-user.h:826: error: field 'obj' has incomplete type
struct nfsd_expkey_get_reqs_rsp obj ...
nfsd-user.c:1211: error: 'nfsd_svc_export_get_reqs_rsp_parse'
undeclared
sunrpc_cache.yaml has the same defect in ip-map-get-reqs and
unix-gid-get-reqs, but nfsd.yaml errors out first in the Makefile's
alphabetical build order and hides the sunrpc failures.
These bugs were introduced by incorrect merge conflict resolution.
Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Closes: https://lore.kernel.org/linux-nfs/f6a3ca6d-e5cb-4a5c-9af2-8d2b1ce33ef0@leemhuis.info/
Fixes: 1045ccf519ce30 ("sunrpc: add netlink upcall for the auth.unix.ip cache")
Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
98 lines
3.2 KiB
C
98 lines
3.2 KiB
C
// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
|
|
/* Do not edit directly, auto-generated from: */
|
|
/* Documentation/netlink/specs/sunrpc_cache.yaml */
|
|
/* YNL-GEN kernel source */
|
|
/* To regenerate run: tools/net/ynl/ynl-regen.sh */
|
|
|
|
#include <net/netlink.h>
|
|
#include <net/genetlink.h>
|
|
|
|
#include "netlink.h"
|
|
|
|
#include <uapi/linux/sunrpc_netlink.h>
|
|
|
|
/* Common nested types */
|
|
const struct nla_policy sunrpc_ip_map_nl_policy[SUNRPC_A_IP_MAP_EXPIRY + 1] = {
|
|
[SUNRPC_A_IP_MAP_SEQNO] = { .type = NLA_U64, },
|
|
[SUNRPC_A_IP_MAP_CLASS] = { .type = NLA_NUL_STRING, },
|
|
[SUNRPC_A_IP_MAP_ADDR] = { .type = NLA_NUL_STRING, },
|
|
[SUNRPC_A_IP_MAP_DOMAIN] = { .type = NLA_NUL_STRING, },
|
|
[SUNRPC_A_IP_MAP_NEGATIVE] = { .type = NLA_FLAG, },
|
|
[SUNRPC_A_IP_MAP_EXPIRY] = { .type = NLA_U64, },
|
|
};
|
|
|
|
const struct nla_policy sunrpc_unix_gid_nl_policy[SUNRPC_A_UNIX_GID_EXPIRY + 1] = {
|
|
[SUNRPC_A_UNIX_GID_SEQNO] = { .type = NLA_U64, },
|
|
[SUNRPC_A_UNIX_GID_UID] = { .type = NLA_U32, },
|
|
[SUNRPC_A_UNIX_GID_GIDS] = { .type = NLA_U32, },
|
|
[SUNRPC_A_UNIX_GID_NEGATIVE] = { .type = NLA_FLAG, },
|
|
[SUNRPC_A_UNIX_GID_EXPIRY] = { .type = NLA_U64, },
|
|
};
|
|
|
|
/* SUNRPC_CMD_IP_MAP_SET_REQS - do */
|
|
static const struct nla_policy sunrpc_ip_map_set_reqs_nl_policy[SUNRPC_A_IP_MAP_REQS_REQUESTS + 1] = {
|
|
[SUNRPC_A_IP_MAP_REQS_REQUESTS] = NLA_POLICY_NESTED(sunrpc_ip_map_nl_policy),
|
|
};
|
|
|
|
/* SUNRPC_CMD_UNIX_GID_SET_REQS - do */
|
|
static const struct nla_policy sunrpc_unix_gid_set_reqs_nl_policy[SUNRPC_A_UNIX_GID_REQS_REQUESTS + 1] = {
|
|
[SUNRPC_A_UNIX_GID_REQS_REQUESTS] = NLA_POLICY_NESTED(sunrpc_unix_gid_nl_policy),
|
|
};
|
|
|
|
/* SUNRPC_CMD_CACHE_FLUSH - do */
|
|
static const struct nla_policy sunrpc_cache_flush_nl_policy[SUNRPC_A_CACHE_FLUSH_MASK + 1] = {
|
|
[SUNRPC_A_CACHE_FLUSH_MASK] = NLA_POLICY_MASK(NLA_U32, 0x3),
|
|
};
|
|
|
|
/* Ops table for sunrpc */
|
|
static const struct genl_split_ops sunrpc_nl_ops[] = {
|
|
{
|
|
.cmd = SUNRPC_CMD_IP_MAP_GET_REQS,
|
|
.dumpit = sunrpc_nl_ip_map_get_reqs_dumpit,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DUMP,
|
|
},
|
|
{
|
|
.cmd = SUNRPC_CMD_IP_MAP_SET_REQS,
|
|
.doit = sunrpc_nl_ip_map_set_reqs_doit,
|
|
.policy = sunrpc_ip_map_set_reqs_nl_policy,
|
|
.maxattr = SUNRPC_A_IP_MAP_REQS_REQUESTS,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = SUNRPC_CMD_UNIX_GID_GET_REQS,
|
|
.dumpit = sunrpc_nl_unix_gid_get_reqs_dumpit,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DUMP,
|
|
},
|
|
{
|
|
.cmd = SUNRPC_CMD_UNIX_GID_SET_REQS,
|
|
.doit = sunrpc_nl_unix_gid_set_reqs_doit,
|
|
.policy = sunrpc_unix_gid_set_reqs_nl_policy,
|
|
.maxattr = SUNRPC_A_UNIX_GID_REQS_REQUESTS,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = SUNRPC_CMD_CACHE_FLUSH,
|
|
.doit = sunrpc_nl_cache_flush_doit,
|
|
.policy = sunrpc_cache_flush_nl_policy,
|
|
.maxattr = SUNRPC_A_CACHE_FLUSH_MASK,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
};
|
|
|
|
static const struct genl_multicast_group sunrpc_nl_mcgrps[] = {
|
|
[SUNRPC_NLGRP_NONE] = { "none", },
|
|
[SUNRPC_NLGRP_EXPORTD] = { "exportd", },
|
|
};
|
|
|
|
struct genl_family sunrpc_nl_family __ro_after_init = {
|
|
.name = SUNRPC_FAMILY_NAME,
|
|
.version = SUNRPC_FAMILY_VERSION,
|
|
.netnsok = true,
|
|
.parallel_ops = true,
|
|
.module = THIS_MODULE,
|
|
.split_ops = sunrpc_nl_ops,
|
|
.n_split_ops = ARRAY_SIZE(sunrpc_nl_ops),
|
|
.mcgrps = sunrpc_nl_mcgrps,
|
|
.n_mcgrps = ARRAY_SIZE(sunrpc_nl_mcgrps),
|
|
};
|