From dcd1f3138a4ef5ada17df21646f24b41ea41491b Mon Sep 17 00:00:00 2001 From: Jeong YunWon Date: Thu, 10 Oct 2019 12:33:00 +0900 Subject: [PATCH] Use `is` for bool comparison --- tests/snippets/bools.py | 14 +++++++------- tests/snippets/ints.py | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/snippets/bools.py b/tests/snippets/bools.py index e3d824b5c..5bb12ee8d 100644 --- a/tests/snippets/bools.py +++ b/tests/snippets/bools.py @@ -14,12 +14,12 @@ assert not 0.0 assert not None -assert bool() == False -assert bool(1) == True -assert bool({}) == False +assert bool() is False +assert bool(1) is True +assert bool({}) is False -assert bool(NotImplemented) == True -assert bool(...) == True +assert bool(NotImplemented) is True +assert bool(...) is True if not 1: raise BaseException @@ -105,8 +105,8 @@ class TestMagicMethodLenOne: return 1 -assert bool(TestMagicMethodLenZero()) == False -assert bool(TestMagicMethodLenOne()) == True +assert bool(TestMagicMethodLenZero()) is False +assert bool(TestMagicMethodLenOne()) is True # check __len__ and __bool__ diff --git a/tests/snippets/ints.py b/tests/snippets/ints.py index c5a0b0ac3..bffdc103d 100644 --- a/tests/snippets/ints.py +++ b/tests/snippets/ints.py @@ -23,12 +23,12 @@ assert int("101", base=2) == 5 # magic methods should only be implemented for other ints -assert (1).__eq__(1) == True -assert (1).__ne__(1) == False -assert (1).__gt__(1) == False -assert (1).__ge__(1) == True -assert (1).__lt__(1) == False -assert (1).__le__(1) == True +assert (1).__eq__(1) is True +assert (1).__ne__(1) is False +assert (1).__gt__(1) is False +assert (1).__ge__(1) is True +assert (1).__lt__(1) is False +assert (1).__le__(1) is True assert (1).__add__(1) == 2 assert (1).__radd__(1) == 2 assert (2).__sub__(1) == 1