From cc809f3237b71ca147fc367398de0f9d458388bf Mon Sep 17 00:00:00 2001 From: "Kim, YeonWoo" Date: Sat, 29 Oct 2022 02:35:55 +0900 Subject: [PATCH] Fix `repr` for union --- Lib/test/test_types.py | 2 -- vm/src/builtins/union.rs | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py index ba031c061..6e3833738 100644 --- a/Lib/test/test_types.py +++ b/Lib/test/test_types.py @@ -929,8 +929,6 @@ class UnionTests(unittest.TestCase): assert typing.Optional[int] | str == typing.Union[int, str, None] assert typing.Union[int, bool] | str == typing.Union[int, bool, str] - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_or_type_repr(self): assert repr(int | str) == "int | str" assert repr((int | str) | list) == "int | str | list" diff --git a/vm/src/builtins/union.rs b/vm/src/builtins/union.rs index d61198dfe..3f8905f14 100644 --- a/vm/src/builtins/union.rs +++ b/vm/src/builtins/union.rs @@ -43,7 +43,7 @@ impl PyUnion { #[pymethod(magic)] fn repr(&self, vm: &VirtualMachine) -> PyResult { fn repr_item(obj: PyObjectRef, vm: &VirtualMachine) -> PyResult { - if vm.is_none(&obj) { + if obj.is(vm.ctx.types.none_type) { return Ok("None".to_string()); }