From 0e33be9ce81fda4b352908d30ca7c5c453ec4e5b Mon Sep 17 00:00:00 2001 From: jfh Date: Fri, 18 Jun 2021 21:24:46 +0300 Subject: [PATCH 1/2] Please clippy --- jit/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jit/src/lib.rs b/jit/src/lib.rs index d0f404f2d..01a860b33 100644 --- a/jit/src/lib.rs +++ b/jit/src/lib.rs @@ -273,7 +273,7 @@ union UnTypedAbiValue { } impl UnTypedAbiValue { - unsafe fn to_typed(&self, ty: &JitType) -> AbiValue { + unsafe fn to_typed(self, ty: &JitType) -> AbiValue { match ty { JitType::Int => AbiValue::Int(self.int), JitType::Float => AbiValue::Float(self.float), From 8540767f58366ac96873d4291e382093fa952a83 Mon Sep 17 00:00:00 2001 From: jfh Date: Fri, 18 Jun 2021 21:58:27 +0300 Subject: [PATCH 2/2] Fix new clippy issues, Use take. --- vm/src/builtins/list.rs | 2 +- vm/src/dictdatatype.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vm/src/builtins/list.rs b/vm/src/builtins/list.rs index 91f57befa..8bdf5058a 100644 --- a/vm/src/builtins/list.rs +++ b/vm/src/builtins/list.rs @@ -132,7 +132,7 @@ impl PyList { #[pymethod] fn clear(&self) { - let _removed = std::mem::replace(self.borrow_vec_mut().deref_mut(), Vec::new()); + let _removed = std::mem::take(self.borrow_vec_mut().deref_mut()); } #[pymethod] diff --git a/vm/src/dictdatatype.rs b/vm/src/dictdatatype.rs index e3bc1b471..925193f83 100644 --- a/vm/src/dictdatatype.rs +++ b/vm/src/dictdatatype.rs @@ -304,7 +304,7 @@ impl Dict { inner.used = 0; inner.filled = 0; // defer dec rc - std::mem::replace(&mut inner.entries, Vec::new()) + std::mem::take(&mut inner.entries) }; }