From bd12982b06af56a4aca53eafe29a76a37e2fc66c Mon Sep 17 00:00:00 2001 From: Daniel Watkins Date: Fri, 31 Aug 2018 18:35:00 -0400 Subject: [PATCH] Implement None == None Fixes #111 --- tests/snippets/json_snippet.py | 2 +- vm/src/pyobject.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/snippets/json_snippet.py b/tests/snippets/json_snippet.py index 389159aea..a83d8b35d 100644 --- a/tests/snippets/json_snippet.py +++ b/tests/snippets/json_snippet.py @@ -38,7 +38,7 @@ assert "str" == json.loads('"str"') assert True == json.loads('true') assert False == json.loads('false') # TODO: uncomment once None comparison is implemented -# assert None == json.loads('null') +assert None == json.loads('null') assert [] == json.loads('[]') assert ['a'] == json.loads('["a"]') assert [['a'], 'b'] == json.loads('[["a"], "b"]') diff --git a/vm/src/pyobject.rs b/vm/src/pyobject.rs index 078e03829..3d628a37a 100644 --- a/vm/src/pyobject.rs +++ b/vm/src/pyobject.rs @@ -779,6 +779,7 @@ impl PartialEq for PyObject { } } (PyObjectKind::Boolean { value: a }, PyObjectKind::Boolean { value: b }) => a == b, + (PyObjectKind::None, PyObjectKind::None) => true, _ => panic!( "TypeError in COMPARE_OP: can't compare {:?} with {:?}", self, other