From b76c0a20a83edf64b7a5cbdd90075e3a8a7b6a0c Mon Sep 17 00:00:00 2001 From: Padraic Fanning Date: Sun, 4 Jan 2026 22:47:53 -0500 Subject: [PATCH] Skip certain problematic tests in test_threading --- .github/workflows/ci.yaml | 1 + Lib/test/test_threading.py | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e7d875479..d7893c18c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -118,6 +118,7 @@ env: test.test_multiprocessing_spawn.test_threads test_file_eintr test_subprocess + test_threading ENV_POLLUTING_TESTS_MACOS: >- test.test_multiprocessing_forkserver.test_processes test.test_multiprocessing_forkserver.test_threads diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index a5ee24859..257ed9fb2 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -875,6 +875,10 @@ class ThreadTests(BaseTestCase): finally: threading.settrace(old_trace) + @unittest.skipIf( + sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, + "TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason" + ) # TODO: RUSTPYTHON @unittest.expectedFailure def test_gettrace_all_threads(self): @@ -915,6 +919,10 @@ class ThreadTests(BaseTestCase): finally: threading.setprofile(old_profile) + @unittest.skipIf( + sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, + "TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason" + ) # TODO: RUSTPYTHON @unittest.expectedFailure def test_getprofile_all_threads(self): @@ -1203,6 +1211,7 @@ class ThreadJoinOnShutdown(BaseTestCase): for t in threads: t.join() + @unittest.skip('TODO: RUSTPYTHON FAILURE, WORKER BUG') @support.requires_fork() # TODO: RUSTPYTHON @unittest.expectedFailure @@ -1528,6 +1537,7 @@ class ExceptHookTests(BaseTestCase): restore_default_excepthook(self) super().setUp() + @unittest.skip('TODO: RUSTPYTHON, flaky') def test_excepthook(self): with support.captured_output("stderr") as stderr: thread = ThreadRunFail(name="excepthook thread")