From 8056604102e1c358103cb6ec6b7ebfdcf28d3e4b Mon Sep 17 00:00:00 2001 From: Jack-R-lantern Date: Sat, 9 Oct 2021 17:48:55 +0900 Subject: [PATCH] Add __contains__ in dict_items --- Lib/test/test_dict.py | 2 -- vm/src/builtins/dict.rs | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Lib/test/test_dict.py b/Lib/test/test_dict.py index 8aef739c0..c999c8174 100644 --- a/Lib/test/test_dict.py +++ b/Lib/test/test_dict.py @@ -1300,8 +1300,6 @@ class DictTest(unittest.TestCase): except RuntimeError: # implementation defined pass - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_dictitems_contains_use_after_free(self): class X: def __eq__(self, other): diff --git a/vm/src/builtins/dict.rs b/vm/src/builtins/dict.rs index 85e2fad83..5856fc3ce 100644 --- a/vm/src/builtins/dict.rs +++ b/vm/src/builtins/dict.rs @@ -997,7 +997,7 @@ impl PyDictItems { } let key = needle.fast_getitem(0); let found = zelf.dict().contains(key.clone(), vm)?; - if found == false { + if !found { return Ok(false); } let value = needle.fast_getitem(1);