From 7defbe927be384518907a9aacabdbd7209a7d6d2 Mon Sep 17 00:00:00 2001
From: Hyunji Kim <dev.hjkim@linecorp.com>
Date: Sun, 29 Sep 2019 15:34:25 +0900
Subject: [PATCH] fix error message for __call__ for non-callable objects

---
 vm/src/vm.rs | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/vm/src/vm.rs b/vm/src/vm.rs
index 71e754b96..fb99b285c 100644
--- a/vm/src/vm.rs
+++ b/vm/src/vm.rs
@@ -604,9 +604,14 @@ impl VirtualMachine {
         } else if let Some(PyBuiltinFunction { ref value }) = func_ref.payload() {
             value(self, args)
         } else {
-            // TODO: is it safe to just invoke __call__ otherwise?
-            vm_trace!("invoke __call__ for: {:?}", &func_ref.payload);
-            self.call_method(&func_ref, "__call__", args)
+            if self.is_callable(&func_ref) {
+                self.call_method(&func_ref, "__call__", args)
+            } else {
+                Err(self.new_type_error(format!(
+                    "'{}' object is not callable",
+                    func_ref.class().name
+                )))
+            }
         }
     }