From 3daabbd2bef27aebf47a32e50ef97b56da685efc Mon Sep 17 00:00:00 2001
From: "Jeong, YunWon" <jeong@youknowone.org>
Date: Fri, 30 Jan 2026 19:21:01 +0900
Subject: [PATCH] Fix weakref

---
 crates/vm/src/builtins/weakref.rs | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/crates/vm/src/builtins/weakref.rs b/crates/vm/src/builtins/weakref.rs
index 327c0fd14..19f3f44f0 100644
--- a/crates/vm/src/builtins/weakref.rs
+++ b/crates/vm/src/builtins/weakref.rs
@@ -15,6 +15,7 @@ use crate::{
 pub use crate::object::PyWeak;
 
 #[derive(FromArgs)]
+#[allow(dead_code)]
 pub struct WeakNewArgs {
     #[pyarg(positional)]
     referent: PyObjectRef,
@@ -41,8 +42,20 @@ impl Constructor for PyWeak {
     type Args = WeakNewArgs;
 
     fn slot_new(cls: PyTypeRef, args: FuncArgs, vm: &VirtualMachine) -> PyResult {
-        let Self::Args { referent, callback } = args.bind(vm)?;
-        let weak = referent.downgrade_with_typ(callback.into_option(), cls, vm)?;
+        // PyArg_UnpackTuple: only process positional args, ignore kwargs.
+        // Subclass __init__ will handle extra kwargs.
+        let mut positional = args.args.into_iter();
+        let referent = positional.next().ok_or_else(|| {
+            vm.new_type_error("__new__ expected at least 1 argument, got 0".to_owned())
+        })?;
+        let callback = positional.next();
+        if let Some(_extra) = positional.next() {
+            return Err(vm.new_type_error(format!(
+                "__new__ expected at most 2 arguments, got {}",
+                3 + positional.count()
+            )));
+        }
+        let weak = referent.downgrade_with_typ(callback, cls, vm)?;
         Ok(weak.into())
     }