From f2922e3f2519f149bea128e222148042db7290f0 Mon Sep 17 00:00:00 2001
From: romab <roma.bessonov@gmail.com>
Date: Sun, 23 Jun 2019 11:34:12 +0500
Subject: [PATCH 1/2] add bytearray and bytes input types for ord()

---
 vm/src/builtins.rs | 48 ++++++++++++++++++++++++++++++++--------------
 1 file changed, 34 insertions(+), 14 deletions(-)

diff --git a/vm/src/builtins.rs b/vm/src/builtins.rs
index 570b1fbbf..9eaafbf73 100644
--- a/vm/src/builtins.rs
+++ b/vm/src/builtins.rs
@@ -28,6 +28,7 @@ use crate::pyobject::{
 };
 use crate::vm::VirtualMachine;
 
+use crate::obj::objbyteinner::PyByteInner;
 #[cfg(not(target_arch = "wasm32"))]
 use crate::stdlib::io::io_open;
 
@@ -530,20 +531,39 @@ fn builtin_oct(vm: &VirtualMachine, args: PyFuncArgs) -> PyResult {
 }
 
 fn builtin_ord(vm: &VirtualMachine, args: PyFuncArgs) -> PyResult {
-    arg_check!(vm, args, required = [(string, Some(vm.ctx.str_type()))]);
-    let string = objstr::borrow_value(string);
-    let string_len = string.chars().count();
-    if string_len != 1 {
-        return Err(vm.new_type_error(format!(
-            "ord() expected a character, but string of length {} found",
-            string_len
-        )));
-    }
-    match string.chars().next() {
-        Some(character) => Ok(vm.context().new_int(character as i32)),
-        None => Err(vm.new_type_error(
-            "ord() could not guess the integer representing this character".to_string(),
-        )),
+    arg_check!(vm, args, required = [(string, None)]);
+    if objtype::isinstance(string, &vm.ctx.str_type()) {
+        let string = objstr::borrow_value(string);
+        let string_len = string.chars().count();
+        if string_len != 1 {
+            return Err(vm.new_type_error(format!(
+                "ord() expected a character, but string of length {} found",
+                string_len
+            )));
+        }
+        match string.chars().next() {
+            Some(character) => Ok(vm.context().new_int(character as i32)),
+            None => Err(vm.new_type_error(
+                "ord() could not guess the integer representing this character".to_string(),
+            )),
+        }
+    } else if objtype::isinstance(string, &vm.ctx.bytearray_type())
+        || objtype::isinstance(string, &vm.ctx.bytes_type())
+    {
+        let inner = PyByteInner::try_from_object(vm, string.clone()).unwrap();
+        let bytes_len = inner.elements.len();
+        if bytes_len != 1 {
+            return Err(vm.new_type_error(format!(
+                "ord() expected a character, but string of length {} found",
+                bytes_len
+            )));
+        }
+        Ok(vm.context().new_int(inner.elements[0]))
+    } else {
+        Err(vm.new_type_error(format!(
+            "ord() expected a string, bytes or bytearray, but found {}",
+            string.class().name
+        )))
     }
 }
 

From 7effca35332dd2d2bf87e3084ce44e0459ad321a Mon Sep 17 00:00:00 2001
From: romab <roma.bessonov@gmail.com>
Date: Sun, 23 Jun 2019 23:24:01 +0500
Subject: [PATCH 2/2] added tests for ord() in tests/snippets

---
 tests/snippets/builtin_ord.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/snippets/builtin_ord.py b/tests/snippets/builtin_ord.py
index 2549f28e7..c9bc40f5f 100644
--- a/tests/snippets/builtin_ord.py
+++ b/tests/snippets/builtin_ord.py
@@ -3,7 +3,11 @@ from testutils import assert_raises
 assert ord("a") == 97
 assert ord("é") == 233
 assert ord("🤡") == 129313
+assert ord(b'a') == 97
+assert ord(bytearray(b'a')) == 97
 
 assert_raises(TypeError, lambda: ord(), "ord() is called with no argument")
 assert_raises(TypeError, lambda: ord(""), "ord() is called with an empty string")
 assert_raises(TypeError, lambda: ord("ab"), "ord() is called with more than one character")
+assert_raises(TypeError, lambda: ord(b"ab"), "ord() expected a character, but string of length 2 found")
+assert_raises(TypeError, lambda: ord(1), "ord() expected a string, bytes or bytearray, but found int")