From 24176f7bbb8b4e6caecbdd5f23e70c4bb6686c0f Mon Sep 17 00:00:00 2001 From: janczer Date: Wed, 20 Feb 2019 06:57:53 +0100 Subject: [PATCH] Add more test for bytearray.pop and fix the panic message --- tests/snippets/bytearray.py | 9 +++++++++ vm/src/obj/objbytes.rs | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/snippets/bytearray.py b/tests/snippets/bytearray.py index 30f2fa690..1b0830f33 100644 --- a/tests/snippets/bytearray.py +++ b/tests/snippets/bytearray.py @@ -43,3 +43,12 @@ c = bytearray([123, 255, 111]) assert len(c) == 3 c.pop() assert len(c) == 2 +c.pop() +c.pop() + +try: + c.pop() +except IndexError: + pass +else: + assert False diff --git a/vm/src/obj/objbytes.rs b/vm/src/obj/objbytes.rs index 459e83fe0..11a0c7b0b 100644 --- a/vm/src/obj/objbytes.rs +++ b/vm/src/obj/objbytes.rs @@ -185,7 +185,7 @@ pub fn get_value<'a>(obj: &'a PyObjectRef) -> impl Deref> + 'a if let PyObjectPayload::Bytes { ref value } = py_obj.payload { value } else { - panic!("Inner error getting int {:?}", obj); + panic!("Inner error getting bytearray {:?}", obj); } }) } @@ -195,7 +195,7 @@ pub fn get_mut_value<'a>(obj: &'a PyObjectRef) -> impl DerefMut if let PyObjectPayload::Bytes { ref mut value } = py_obj.payload { value } else { - panic!("Inner error getting int {:?}", obj); + panic!("Inner error getting bytearray {:?}", obj); } }) }