From 14cb5dd8740f40f5410703c8f102eb35faeca7b5 Mon Sep 17 00:00:00 2001 From: Shahar Naveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Tue, 2 Jun 2026 12:07:32 +0300 Subject: [PATCH] Remove node24 installation. It's the default now (#8014) * Remove node24 installation. It's the default now * Fix insta tests for llvm-cov --- .github/workflows/ci.yaml | 7 ------- .github/workflows/cron-ci.yaml | 3 ++- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3ff74e6a5..574a0bbb2 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -33,7 +33,6 @@ env: CARGO_PROFILE_DEV_DEBUG: 0 CARGO_PROFILE_RELEASE_DEBUG: 0 CARGO_TERM_COLOR: always - FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true # TODO: Remove on 2026/06/02 CI: true jobs: @@ -541,12 +540,6 @@ jobs: key: prek-${{ hashFiles('.pre-commit-config.yaml') }} path: ~/.cache/prek - # TODO: Remove on 2026/06/02 when node24 is the default - - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 - with: - package-manager-cache: false - node-version: "24" - - name: install prek id: prek uses: j178/prek-action@bdca6f102f98e2b4c7029491a53dfd366469e33d # v2.0.4 diff --git a/.github/workflows/cron-ci.yaml b/.github/workflows/cron-ci.yaml index ac1a1cadb..9c2f13524 100644 --- a/.github/workflows/cron-ci.yaml +++ b/.github/workflows/cron-ci.yaml @@ -15,7 +15,6 @@ on: env: CARGO_ARGS: --no-default-features --features stdlib,importlib,stdio,encodings,ssl-rustls-aws-lc,jit,host_env - FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: 'true' # TODO: Remove on 2026/06/02 jobs: # codecov collects code coverage data from the rust tests, python snippets and python test suite. @@ -25,6 +24,8 @@ jobs: runs-on: ubuntu-latest # Disable this scheduled job when running on a fork. if: ${{ github.repository == 'RustPython/RustPython' || github.event_name != 'schedule' }} + env: + INSTA_WORKSPACE_ROOT: ${{ github.workspace }} steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: